Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Remove commented code #17136

Merged
merged 1 commit into from
Jul 27, 2018
Merged

[Backport] Remove commented code #17136

merged 1 commit into from
Jul 27, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Jul 25, 2018 •
edited
Loading

Description

Removed commented code and make it cleaner more.

Fixed Issues (if relevant)

  1. Remove commented code #16891: Remove commented code

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@nuzil nuzil self-assigned this Jul 25, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jul 25, 2018
@nuzil nuzil self-requested a review July 26, 2018 19:30
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-2541 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 8099f16 into magento:2.1-develop Jul 27, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 27, 2018
ENGCOM-2541: [Backport] Remove commented code #17136
ef8aa5a
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuzil nuzil nuzil approved these changes

Assignees

@nuzil nuzil

Labels
Area: Frontend Cleanup Component: Backend Component: Catalog Component: Newsletter Component: Sales Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
3 participants
@mage2pratik @magento-engcom-team @nuzil