Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Improve attribute checking #17249

Closed
wants to merge 4 commits into from
Closed

[Backport] Improve attribute checking #17249

wants to merge 4 commits into from

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#11554
On a store with a large number of attribute sets, a lot of repeated checking is done for the same attributes.

Description

Instead of repeating the checks every time, keep track of the attributes that have already been checked and should be skipped (invisible). This we way we don't have to do the same check for the next attribute set.

Fixed Issues (if relevant)

Manual testing scenarios

  1. Create a store with a large number of attribute sets, and add some invisible attributes in those sets
  2. Upload a csv file with products to import, and click the Check Data button

With this change the checking phase will be much faster than without the change, without any functional change.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Freek Vandeursen added 4 commits July 28, 2018 20:15
On a store with a large number of attribute sets, a lot of repeated checking is done for the same attributes.
So instead we can keep track of the attributes we already checked, and skip them the next time.
@sidolov
Copy link
Contributor

sidolov commented Jul 31, 2018

@mage2pratik , please, take a look at failed tests

@sidolov
Copy link
Contributor

sidolov commented Aug 14, 2018

Hi @mage2pratik , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants