Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Solution for User role issue with customer group #17574

Merged
merged 1 commit into from
Aug 19, 2018
Merged

[Forwardport] Solution for User role issue with customer group #17574

merged 1 commit into from
Aug 19, 2018

Conversation

jignesh-baldha
Copy link
Member

Original Pull Request

#17515

Description

Now the “customer group” menu is displayed under "customers" menu on the admin side and store menu is invisible for new user. issue was is ACL file.
In ACL file 'Customer group should be in 'Magento_Customer::customer' instead of 'Magento_Backend::stores_other_settings'.

Fixed Issues (if relevant)

  1. User role issue with customer group #16499: User role issue with customer group User role issue with customer group #16499

Manual testing scenarios

1 .System > Permission > User Roles.
2. Create a user role with 'customer group' permission which is specified in issue steps.
3. Login with new user credential. now only customer menu is enabled and store menu is not visible for new user.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@jignesh-baldha jignesh-baldha deleted the 2.3-develop-PR-port-17515 branch August 27, 2018 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants