Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix unstable session manager #17608

Merged
merged 7 commits into from
Sep 12, 2018
Merged

[Forwardport] Fix unstable session manager #17608

merged 7 commits into from
Sep 12, 2018

Conversation

jignesh-baldha
Copy link
Member

@jignesh-baldha jignesh-baldha commented Aug 14, 2018

Original Pull Request

#14973

Description

Fix of the unstable behaviour of the session management with high volume of concurrent sessions.

Fixed Issues

  1. Concurrent (quick reload) requests on checkout cause cart to empty - related to session_regenerate_id #12362: Concurrent (quick reload) requests on checkout cause cart to empty - related to session_regenerate_id

Manual testing scenarios

  1. Reach the checkout page with products in the cart
  2. Press CMD+R or ALT+F5 multiple times to refresh the page, after the fix the user is not being logged out and redirected to the empty cart page.

We already deployed the fix on our high traffic website and the issue is fixed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@elioermini
Copy link
Member

Hi @magento-engcom-team I'd like to keep credit of the PR as what @jignesh-baldha did was using the automated tool to forward port while I spent weeks for the solution.

@gabrieljadeau
Copy link

Somebody could provide the patch for m2.2.5?

THanks :)

@kennedyabitbol
Copy link

Seems to be confirmed on 2.2.4, ENGCOM-2794 works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants