Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] 16544: fixed behaviour when some of JS validation rules making fields required #17724

Merged
merged 5 commits into from
Sep 12, 2018
Merged

Conversation

nmalevanec
Copy link
Contributor

Original Pull Request

#16724

Description

Fixed rules which make fields required:
max-words
min-words
range-words
letters-with-basic-punc
alphanumeric
letters-only
no-whitespace
zip-range
integer
vinUS
time
time12h
phoneUS
phoneUK
mobileUK
email2
url2
credit-card-types
ipv4
ipv6
pattern
validate-cc-number
validate-per-page-value-list

new form content magento admin

Fixed Issues (if relevant)

  1. Some of JS validation rules making fields required #16544: Some of JS validation rules making fields required

Manual testing scenarios

  1. Create a new module with form and field, or add a field to existing form
  2. Set field validation, for example:
    <validation> <rule name="phoneUS" xsi:type="boolean">true</rule> </validation>
  3. Field should not be required

Steps to reproduce

  1. Don't fill out the field just submit a form

Expected result

  1. The form is submitting as well

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2861 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants