Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding example RewriteBase to static/.htaccess for Apache users #1797

Conversation

steverobbins
Copy link
Contributor

@steverobbins steverobbins commented Sep 4, 2015

Similar to the example configuration in pub/.htaccess, I'd like to add one here. My local install wouldn't work without it. This hint would have helped me track down the issue sooner.

@cmuench
Copy link
Contributor

cmuench commented Sep 5, 2015

+1

@antonkril
Copy link
Contributor

antonkril commented Sep 15, 2015

What's the issue with local install? Why would it not work without it. Can you describe problem more?

@vancoz
Copy link

vancoz commented Sep 15, 2015

@steverobbins could you please address @antonkril 's question?

@steverobbins
Copy link
Contributor Author

@antonkril Without it, I get the following error in /var/log/httpd/error_log

[Tue Sep 15 17:34:12 2015] [error] [client 192.168.50.1] Request exceeded the limit of 10 internal redirects due to probable configuration error. Use 'LimitInternalRecursion' to increase the limit if necessary. Use 'LogLevel debug' to get a backtrace.

I notice this behavior when using MAMP or CentOS 6.5 with Apache 2.2.15 (vagrant)

@buskamuza
Copy link
Contributor

@steverobbins , could you, please, provide your Apache configuration, including configuration for the virtual host?
As I understand, you have Magento installed under <document_root>/magento? Do you use something like http://httpd.apache.org/docs/2.2/vhosts/mass.html or other configuration for multiple virtual hosts?

So we could better document in which case this setting is needed.

@steverobbins
Copy link
Contributor Author

I will work on getting you the files you asked for, but really I don't feel I need to explain this any more than I need to explain why it's already in these places. I'm just trying to keep things consistent.

@steverobbins
Copy link
Contributor Author

Here are a few articles on the same issue

The solution for these users was to add a RewriteBase or to change

RewriteRule .* index.php [L]

to

RewriteRule .* /index.php [L]

Here are relevant configuration files: https://gist.github.com/steverobbins/d799bffe47719083db7e

Again, I just want to add this commented out line so that users who experience this issue will have a hint as to how to solve it. This is consistent with the main .htaccess file. It will not effect any existing installs.

@magento-cicd2
Copy link
Contributor

We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects.
Please see the CLA agreement in the Pull Request comments below.

@steverobbins
Copy link
Contributor Author

This has been marked as accept for over two months. Will it be merged in?

@KrystynaKabannyk
Copy link

KrystynaKabannyk commented Apr 21, 2016

hello @steverobbins, thanks so much for your pull request, the proposed changes look good to us, and we plan to merge it in one of the nearest releases. However, we would highly appreciate if you update the code and cover it by automated tests (the checks circle has to be green), so we could merge it earlier.

@steverobbins steverobbins force-pushed the feature/static-htaccess-rewritebase branch from 5504f9e to 28af806 Compare April 21, 2016 17:38
@steverobbins
Copy link
Contributor Author

steverobbins commented Apr 21, 2016

@KrystynaKabannyk If you look at the contents of this PR you will see that

  • The changes don't warrant a test
  • The changes aren't testable
  • The tests are failing for issues unrelated to this PR

Regardless, I have rebased on develop to trigger a new test.

@steverobbins steverobbins force-pushed the feature/static-htaccess-rewritebase branch from 28af806 to 39ba5e1 Compare August 2, 2016 15:44
@vkorotun vkorotun added Area: Frontend improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed PS labels Aug 3, 2016
@vkorotun vkorotun added linked and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 5, 2016
@steverobbins
Copy link
Contributor Author

@VladimirZaets Is there a reason why this was rejected? It's been marked as accept for some time.

magento-team pushed a commit that referenced this pull request Dec 12, 2017
magento-engcom-team added a commit that referenced this pull request Sep 7, 2020
…age preview #29869

 - Merge Pull Request #29869 from joweecaquicla/magento2:1797-vertical-image-not-centered-in-category-image-preview
 - Merged commits:
   1. c60dd36
   2. 28d04b0
   3. 45ebee4
magento-engcom-team pushed a commit that referenced this pull request Sep 7, 2020
Accepted Community Pull Requests:
 - #29831: [MFTF] add new  AdminOpenCatalogSearchTermIndexPageActionGroup (by @Usik2203)
 - #29869: #1797: The vertical image is not centered in Category image preview (by @joweecaquicla)
 - #29875: #1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest (by @joweecaquicla)
 - #27386: Aria-atomic="true" missing on error container (by @bradleybrecher)
 - #29044: Improvements webfont loading for theme (by @mrtuvn)
 - #29822: [MFTF]  Add new  AdminOpenIndexManagementPageActionGroup (by @Usik2203)
 - #29836: [MFTF] add AssertStorefrontCustomerLogoutSuccessPageActionGroup (by @Usik2203)
 - #28349: Replaced deprecated method addError with addErrorMessage (by @VinothKumar361)


Fixed GitHub Issues:
 - #29844: [Issue] [MFTF] add new  AdminOpenCatalogSearchTermIndexPageActionGroup (reported by @m2-assistant[bot]) has been fixed in #29831 by @Usik2203 in 2.4-develop branch
   Related commits:
     1. 2d9d741
     2. 41d0ada

 - #29560: [Issue] Aria-atomic="true" missing on error container (reported by @m2-assistant[bot]) has been fixed in #27386 by @bradleybrecher in 2.4-develop branch
   Related commits:
     1. 8f08efe
     2. a75c7f6
     3. 27555c2
     4. 2e90fad
     5. 2738a61
     6. 7939d99
     7. 7436d57
     8. b91ebf2
     9. 1e28435
     10. 65387f8

 - #29526: [Issue] Improvements webfont loading for theme (reported by @m2-assistant[bot]) has been fixed in #29044 by @mrtuvn in 2.4-develop branch
   Related commits:
     1. be3c1ec

 - #29825: [Issue] [MFTF]  Add new  AdminOpenIndexManagementPageActionGroup (reported by @m2-assistant[bot]) has been fixed in #29822 by @Usik2203 in 2.4-develop branch
   Related commits:
     1. b991d9a
     2. 6c103a7
     3. 4dfb45e

 - #29841: [Issue] [MFTF] add AssertStorefrontCustomerLogoutSuccessPageActionGroup (reported by @m2-assistant[bot]) has been fixed in #29836 by @Usik2203 in 2.4-develop branch
   Related commits:
     1. 5228d6b
     2. 889369c
     3. 6cd78b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants