New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding example RewriteBase to static/.htaccess for Apache users #1797
Adding example RewriteBase to static/.htaccess for Apache users #1797
Conversation
+1 |
What's the issue with local install? Why would it not work without it. Can you describe problem more? |
@steverobbins could you please address @antonkril 's question? |
@antonkril Without it, I get the following error in
I notice this behavior when using MAMP or CentOS 6.5 with Apache 2.2.15 (vagrant) |
@steverobbins , could you, please, provide your Apache configuration, including configuration for the virtual host? So we could better document in which case this setting is needed. |
Here are a few articles on the same issue
The solution for these users was to add a
to
Here are relevant configuration files: https://gist.github.com/steverobbins/d799bffe47719083db7e Again, I just want to add this commented out line so that users who experience this issue will have a hint as to how to solve it. This is consistent with the main |
We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects. |
This has been marked as |
hello @steverobbins, thanks so much for your pull request, the proposed changes look good to us, and we plan to merge it in one of the nearest releases. However, we would highly appreciate if you update the code and cover it by automated tests (the checks circle has to be green), so we could merge it earlier. |
5504f9e
to
28af806
Compare
@KrystynaKabannyk If you look at the contents of this PR you will see that
Regardless, I have rebased on |
28af806
to
39ba5e1
Compare
@VladimirZaets Is there a reason why this was rejected? It's been marked as |
Accepted Community Pull Requests: - #29831: [MFTF] add new AdminOpenCatalogSearchTermIndexPageActionGroup (by @Usik2203) - #29869: #1797: The vertical image is not centered in Category image preview (by @joweecaquicla) - #29875: #1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest (by @joweecaquicla) - #27386: Aria-atomic="true" missing on error container (by @bradleybrecher) - #29044: Improvements webfont loading for theme (by @mrtuvn) - #29822: [MFTF] Add new AdminOpenIndexManagementPageActionGroup (by @Usik2203) - #29836: [MFTF] add AssertStorefrontCustomerLogoutSuccessPageActionGroup (by @Usik2203) - #28349: Replaced deprecated method addError with addErrorMessage (by @VinothKumar361) Fixed GitHub Issues: - #29844: [Issue] [MFTF] add new AdminOpenCatalogSearchTermIndexPageActionGroup (reported by @m2-assistant[bot]) has been fixed in #29831 by @Usik2203 in 2.4-develop branch Related commits: 1. 2d9d741 2. 41d0ada - #29560: [Issue] Aria-atomic="true" missing on error container (reported by @m2-assistant[bot]) has been fixed in #27386 by @bradleybrecher in 2.4-develop branch Related commits: 1. 8f08efe 2. a75c7f6 3. 27555c2 4. 2e90fad 5. 2738a61 6. 7939d99 7. 7436d57 8. b91ebf2 9. 1e28435 10. 65387f8 - #29526: [Issue] Improvements webfont loading for theme (reported by @m2-assistant[bot]) has been fixed in #29044 by @mrtuvn in 2.4-develop branch Related commits: 1. be3c1ec - #29825: [Issue] [MFTF] Add new AdminOpenIndexManagementPageActionGroup (reported by @m2-assistant[bot]) has been fixed in #29822 by @Usik2203 in 2.4-develop branch Related commits: 1. b991d9a 2. 6c103a7 3. 4dfb45e - #29841: [Issue] [MFTF] add AssertStorefrontCustomerLogoutSuccessPageActionGroup (reported by @m2-assistant[bot]) has been fixed in #29836 by @Usik2203 in 2.4-develop branch Related commits: 1. 5228d6b 2. 889369c 3. 6cd78b5
Similar to the example configuration in
pub/.htaccess
, I'd like to add one here. My local install wouldn't work without it. This hint would have helped me track down the issue sooner.