Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1797: The vertical image is not centered in Category image preview #29869

Merged
merged 3 commits into from
Sep 7, 2020
Merged

#1797: The vertical image is not centered in Category image preview #29869

merged 3 commits into from
Sep 7, 2020

Conversation

joweecaquicla
Copy link

Description (*)

This PR will introduce the fix to align the position of vertical images to centre in category image preview.

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes The vertical image is not centered in Category image preview adobe-stock-integration#1797

Manual testing scenarios (*)

  1. A vertical image saved to Media gallery
    To save a vertical image to Media Gallery, perform the following steps:
  • Open Search Adobe Stock
  • Click Filters
  • Select Orientation - Vertical
  • Apply Filters
  • Save Preview of one the found Vertical images
  1. Go to Catalog - Categories
  2. Expand Content and click Select from Gallery
  3. Select the previously saved Vertical image and click Add Selected
  4. The preview image should be centered.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

magento/adobe-stock-integration#1797: The vertical image is not cente…
c60dd36 
…red in Category image preview - modified preview image position to center
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 2, 2020
@joweecaquicla
Copy link
Author

@magento run all tests

@rogyar rogyar self-assigned this Sep 2, 2020
@rogyar
Copy link
Contributor

rogyar commented Sep 2, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-29869.instances.magento-community.engineering/admin_fac6
Login: 09c98926 Password: 36801d24ba35
Instance will be terminated in up to 3 hours.

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 2, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Sep 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8119 has been created to process this Pull Request

joweecaquicla added 2 commits September 3, 2020 00:36
Merge branch '2.4-develop' of github.com:magento/magento2 into 1797-v…
28d04b0 
…ertical-image-not-centered-in-category-image-preview
magento/adobe-stock-integration#1797: The vertical image is not cente…
45ebee4 
…red in Category image preview - fixed static test and mftf test fails
@joweecaquicla
Copy link
Author

@magento run all tests

@sivaschenko sivaschenko added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Sep 3, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Before switching to PR
Selection_076
After
Selection_080

Added test steps to already existing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1054245/scenarios/4484351

@engcom-Bravo engcom-Bravo self-assigned this Sep 3, 2020
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 3, 2020
@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 3, 2020
@engcom-Bravo engcom-Bravo added Progress: testing in progress QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed Progress: extended testing labels Sep 3, 2020
@sivaschenko sivaschenko moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 3, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 7, 2020
@sidolov
ENGCOM-8119: #1797: The vertical image is not centered in Category im…
2dc1c04 
…age preview #29869
@magento-engcom-team magento-engcom-team merged commit 9adab69 into magento:2.4-develop Sep 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko Awaiting requested review from sivaschenko

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

@engcom-Bravo engcom-Bravo

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: MediaGalleryUi Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The vertical image is not centered in Category image preview
5 participants
@joweecaquicla @rogyar @magento-engcom-team @engcom-Bravo @sivaschenko