[MAGETWO-85227]:+ This commit fixes a incorrect fetch of column value… #18060
Conversation
…s on a loaded collection + Clones a unloaded collection for the grid to use. + Resets the collection to remove the limit of the collection
magento-engcom-team
added
Partner: Guapa
partners-contribution
|
Hi @jspoe. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
|
+ Altered unit test to comply
| * | ||
| * @return \Magento\Framework\Data\Collection | ||
| */ | ||
| public function getUnloadedCollection() |
There was a problem hiding this comment.
It's a breaking change. Please look into the guide https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/
There was a problem hiding this comment.
Hi @slavvka
See my comment in #12594 (comment)
How do you see a solution for this change? Because both won't be good enough, I think.
There was a problem hiding this comment.
Nowadays all changes must be applied to 2.3-develop first (see https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#rules). Please prepare a new pull request, this one should be on hold until the latter is merged.
|
Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened. |
|
Hey @jspoe Anyway this change should be applied to the latest code. Please reopen it to 2.4 |
[MAGETWO-85227]:+ This commit fixes a incorrect fetch of column values on a loaded collection
Description
Clones a unloaded collection for the grid to use.
Resets the collection limit to remove the limit of the collection
Fixed Issues (if relevant)
Manual testing scenarios
Expected Result
All review items are selected.
Expected Result
Only visible review items are selected.
Contribution checklist