Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CategoryProcessor.php #18271

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Conversation

ulftietze
Copy link
Member

@ulftietze ulftietze commented Sep 26, 2018

Description

This fix make it possible, that the upsert category process during product import are generating the freshly created category url rewrites globally and not just for the default scope

Fixed Issues (if relevant)

  1. Product Import -> Upsert Category: Url Rewrites are just created for default website #18234: Product Import -> Upsert Category: Url Rewrites are just created for default website

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ulftietze. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ulftietze
Copy link
Member Author

Can somebody tell me why this test fails? :D

@slavvka slavvka self-assigned this Sep 26, 2018
@slavvka
Copy link
Member

slavvka commented Sep 26, 2018

Hi @ulftietze. The test is failing due to newly introduced PHP DocBlock Validator. Since the test is run only against changed files and you changed the file, it is failing. You could fix the issue if you please or wait until we decide how to deal with such cases.

@ulftietze
Copy link
Member Author

Hey @slavvka,+

thanks for your reply. Can i something to fix this issue or failing test?
How does this DocBlock have to be written?

Thanks and greetz,
Ulf

@slavvka
Copy link
Member

slavvka commented Sep 27, 2018

Hey @ulftietze. I would appreciate if you did that. You could refer to the guide https://devdocs.magento.com/guides/v2.2/coding-standards/docblock-standard-general.html

@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-3083 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@ulftietze thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ulftietze
Copy link
Member Author

Hey @slavvka,

thanks for fixing this :D i had recently no time for this :/

@slavvka
Copy link
Member

slavvka commented Oct 9, 2018

@ulftietze no problem :)

@magento-engcom-team
Copy link
Contributor

Hi @ulftietze. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants