Fix for removing the dirs while creating a TAR archive

[haroldclaus]

Description

The bug caused issues during the export of analytics data from advanced
reporting. The SCANDIR has a parameter where the sort can be determined, but
using UNSORTED gives you unwanted lists of files/dirs. Therefor deleting
the first 2 via array_shift, is not a proper way of dealing with this. With this PR, it doesn't matter how you sort the results of the SCANDIR function, you'll always remove in a proper way the "." and "..".

Fixed Issues (if relevant)

No issues were found about this issue

Manual testing scenarios

• Running of "analytics_collect_data" cronjob and check if the "." and ".." were removed in the result of the scandir PHP function.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @haroldclaus. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-3069 has been created to process this Pull Request

[magento-engcom-team]

@haroldclaus thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @haroldclaus. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

[Ctucker9233]

@magento-engcom-team Has a backport to 2.2 been made yet? If not, I'll do it.

[ihor-sviziev]

@Ctucker9233 backport to 2.2 was already merged. #18283

[ShapesGraphicStudio]

Hello,
Issue solved on Magento 2.2.6 thanks to the fix, but it reappeared in Magento 2.3.0.

[terrybakshi]

such a shame that this issue still messes up your whole website what is even point using magento when the team is busy developing new features and can't even concentrate to fix the bugs and issues in new versions.

[Ctucker9233]

@terrybakshi I agree. Bug fix release should be sped up while keeping code quality in mind. i.e. 20 bug fixes released every month. That seems doable to me.