Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for parsing attribute options labels, when & used. #18354

Conversation

bartoszkubicki
Copy link

@bartoszkubicki bartoszkubicki commented Oct 3, 2018

Description

After updating Magento to 2.2.6 when attribute is saved, and option label contains & label is cut before &. It is caused by usage of function parse_str() which is confused by &

Fixed Issues (if relevant)

Manual testing scenarios

  1. Add attribute option with label containing char &
  2. Save attribute
  3. Check if label wa correctly saved.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3081 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Oct 3, 2018

Hi @bartoszkubicki , please, create the PR with the same fixes to 2.3-develop branch, we are focusing on the 2.3 release line for now and current PR will be merged as port for 2.3-develop.
Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @bartoszkubicki. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants