Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the product image has an hardcoded class
product-image-photo
which can't be overriden when using the$attributes
parameter of theimageBuilder->create()
function.Manual testing scenarios
=> The
img
tag hasmy-custom-class
as class.=> The
img
tag hasproduct-image-photo
as class.The aim here is to allow customization without breaking the default value.
I'm open to discussion about how to deal with this!
Contribution checklist