Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change expected Exception namespace to fix docblock #18530

Closed
wants to merge 1 commit into from
Closed

Change expected Exception namespace to fix docblock #18530

wants to merge 1 commit into from

Conversation

peterjaap
Copy link
Contributor

Description

Change expected Exception from \Magento\NewRelicReporting\Model\Exception to \Exception to fix docblock

Fixed Issues (if relevant)

None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @peterjaap
Thank you for your contribution. This pull request has been combined (merged) with #18529 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

magento-engcom-team added a commit to peterjaap/magento2 that referenced this pull request Oct 11, 2018
@magento-engcom-team
Merge pull request magento#18530 to magento#18529
3ac4a95
@magento-engcom-team magento-engcom-team mentioned this pull request Oct 11, 2018
Merged
4 tasks
@peterjaap peterjaap deleted the fix-exception-docblock branch October 11, 2018 11:53
@peterjaap peterjaap restored the fix-exception-docblock branch October 11, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: NewRelicReporting Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterjaap @magento-engcom-team