Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] #17813 - Huge "product_data_storage" in localStorage hangs the shop #19014

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

omiroshnichenko
Copy link
Contributor

Description

Replace usage of jQuery localStorage API with native localStorage.

Fixed Issues

  1. Huge "product_data_storage" in localStorage hangs the shop #17813: Huge "product_data_storage" in localStorage hangs the shop

Manual testing scenarios

  1. Open the shop.
  2. Visit a lot of different product pages (~400 in our case) without invalidating user data.
  3. Notice that browser does not slow down anymore.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @omiroshnichenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@omiroshnichenko omiroshnichenko changed the title #17813 - Huge "product_data_storage" in localStorage hangs the shop [Backport] #17813 - Huge "product_data_storage" in localStorage hangs the shop Nov 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3373 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @omiroshnichenko. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants