-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.3-develop] magento/magento2#17833: Child theme does not inherit translations fr… #19018
Conversation
Hi @vpodorozh. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @sivaschenko, thank you for the review. |
Thank you for your contribution @vpodorozh ! In result of this change, parent theme translation file will be used if there is no translation file in the current (child) theme. |
Hi @vpodorozh. Thank you for your contribution. |
…me does not inherit translations from parent theme #19023
Accepted Public Pull Requests: - #19365: Fixing a test for Magento Newsletter. (by @tiagosampaio) - #19358: [Backport] Fix the issue with repetitive "tbody" tag for order items table (by @gelanivishal) - #19023: [2.2 develop] [backport #19018] [issue #17833] child theme does not inherit translations from parent theme (by @vpodorozh) Fixed GitHub Issues: - #17833: Child theme does not inherit translations from parent theme (reported by @rossmc) has been fixed in #19023 by @vpodorozh in 2.2-develop branch Related commits: 1. caa2fe8 2. 24330d6 3. 10d9cc9 4. a3db8d3 5. 26ea51e 6. e8a07c9
Description ( #17833 )
Child theme does not inherit translations from parent theme.
Theme inheritance does not work as expected with [translation dictionaries][1]. The child theme does not use any translations defined in it's parent theme's
en_US.csv
translation dictionary.Fixed Issues
Preconditions
I'm working on a Magento ver 2.2.5 installation with two websites & two corresponding theme's. Each with their own [translation dictionary][1], and one theme inheriting from the other.
Manual testing scenarios
"Create New Customer Account","Create New Account"
to the parent theme'sen_US.csv
translation dictionary.Expected result
The page title should be Create New Account
Actual result
The page title is still Create New Customer Account
"Create New Customer Account","Create New Account"
to the Child theme'sen_US.csv
translation dictionary you can see the translation string applied corectly on the website with the child theme applied.Is this a bug with Magento or am I doing something wrong?
Is the [translation dictionary][1] documentation incorrect and this is actually the correct behaviour?
Contribution checklist