Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport]Fix issue #19632 - Backend Marketing Cart Price Rule Label Alignment Issue #19638

Closed

Conversation

speedy008
Copy link
Contributor

Original Pull Request

#19637

Description (*)

Backend Marketing Cart Price Rule Label Alignment Issue
Magento 2.3-Develop

Fixed Issues (if relevant)

  1. Backend Marketing Cart Price Rule Label Alignment Issue #19632: Backend Marketing Cart Price Rule Label Alignment Issue

Manual testing scenarios (*)

1.Open Marketing -> Cart Price Rules ->Store View Specific Labels in Backend
2.Check Help Icon Alignment

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@speedy008 speedy008 closed this Dec 8, 2018
@VladimirZaets VladimirZaets self-assigned this Dec 11, 2018
@speedy008 speedy008 reopened this Jan 12, 2019
@sidolov
Copy link
Contributor

sidolov commented Feb 20, 2019

Hi @speedy008 , current PR does not contain any changed files. Looks like something went wrong with the head branch.
I'm closing this PR, please, fix the branch and reopen it if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Feb 20, 2019
@ghost
Copy link

ghost commented Feb 20, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants