Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #19632 - Backend Marketing Cart Price Rule Label Alignment Issue #19637

Merged
merged 2 commits into from Mar 8, 2019

Conversation

speedy008
Copy link
Contributor

@speedy008 speedy008 commented Dec 8, 2018

Description (*)

Backend Marketing Cart Price Rule Label Alignment Issue
Magento 2.3-Develop

Fixed Issues (if relevant)

1.#19632: Backend Marketing Cart Price Rule Label Alignment Issue

Manual testing scenarios (*)

1.Open Marketing -> Cart Price Rules ->Store View Specific Labels in Backend
2.Check Help Icon Alignment

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3664 has been created to process this Pull Request

@ghost
Copy link

ghost commented Mar 8, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 8, 2019
magento-engcom-team pushed a commit that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants