Special Price shown without currency symbol in magento backoffice

[XxXgeoXxX]

Base issue: #20472

Description (*)

Magento 2.3.X
Magento 2.2.X

Steps to reproduce (*)

Navigate to admin catalog product grid
Using "Columns" selection add 'Special Price' column in the grid

Expected result (*)

Special Price will be shown with currency code

Actual result (*)

Special Price showed without currency code.

Manual testing scenarios (*)

Navigate to admin catalog product grid
Using "Columns" selection add 'Special Price' column in the grid

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @XxXgeoXxX. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-3928 has been created to process this Pull Request

[sivaschenko]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-20474.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[sivaschenko]

Hi @XxXgeoXxX , thanks for the pull request, can you please check the test instance: Special Price column is empty.

[XxXgeoXxX]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @XxXgeoXxX. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @XxXgeoXxX, here is your new Magento instance.
Admin access: https://pr-20474.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[XxXgeoXxX]

Hi @sivaschenko
updated PR. Looks like magento skips values for some column when you enable it this column in BO->Products->Columns but it xml use false and show them only after some event(click/sort per this column)

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-3928 has been created to process this Pull Request

[sidolov]

@XxXgeoXxX , please, resolve merge conflicts

[XxXgeoXxX]

HI @sidolov
merge conflict was resolved

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-3928 has been created to process this Pull Request

[sivaschenko]

Magento\FunctionalTestingFramework.functional\MSI_Multi_Mode.AdminUserSetStatusForEachSourceItemTest functional test is failing on this pull request

[nmalevanec]

Magento\FunctionalTestingFramework.functional\MSI_Multi_Mode.AdminUserSetStatusForEachSourceItemTest functional test is failing on this pull request

@sivaschenko I've created PR to MSI repository, to fix mentioned above test magento/inventory#2068

[ishakhsuvarov]

@sivaschenko @nmalevanec magento/inventory#2068 is now merged.

[sivaschenko]

Magento\FunctionalTestingFramework.functional\MSI_Multi_Mode.AdminUserSetStatusForEachSourceItemTest is failing on this pull request

Failed asserting that any element by '//tr[1]//td[count(//div[@data-role='grid- 
wrapper']//tr//th[normalize-space(.)='Quantity']/preceding-sibling::th) +1 ]' on page 
/admin/catalog/product/index/store/0/
Elements: 
+ <td> 
contains text '100'

[orlangur]

@XxXgeoXxX please elaborate a proper fix, see #20906 (comment).

[sidolov]

@XxXgeoXxX , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.