Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Special Price shown without currency symbol in magento backoffice #20475

Closed
wants to merge 3 commits into from

Conversation

XxXgeoXxX
Copy link
Member

Base issue: #20472

Description (*)

Magento 2.3.X
Magento 2.2.X

Steps to reproduce (*)

Navigate to admin catalog product grid
Using "Columns" selection add 'Special Price' column in the grid

Expected result (*)

Special Price will be shown with currency code

Actual result (*)

Special Price showed without currency code.

Fixed Issues (if relevant)

Backport for #20474

Manual testing scenarios (*)

Navigate to admin catalog product grid
Using "Columns" selection add 'Special Price' column in the grid

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Catalog Release Line: 2.2 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 22, 2019
@XxXgeoXxX
Copy link
Member Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX, here is your new Magento instance.
Admin access: https://pr-20475.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar changed the title BAckport Special Price shown without currency symbol in magento backoffice [backport] Special Price shown without currency symbol in magento backoffice Jan 23, 2019
@XxXgeoXxX
Copy link
Member Author

merge conflict was resolved

@vpodorozh vpodorozh requested review from sivaschenko and removed request for vpodorozh February 20, 2019 12:14
@vpodorozh vpodorozh removed their assignment Feb 20, 2019
@rogyar rogyar self-assigned this Feb 23, 2019
@orlangur orlangur self-assigned this Apr 5, 2019
@sidolov
Copy link
Contributor

sidolov commented Apr 24, 2019

Hi @XxXgeoXxX , I'm closing this PR because original was closed due to inactivity. Please, reopen original PR if you wish to continue.
Thank you!

@sidolov sidolov closed this Apr 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 24, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: on hold Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants