Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #20911 In admin login password forgot password page wrong css used to make it vertially aling middle #20914

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

GovindaSharma
Copy link
Contributor

Fixed issue #20911 In admin login password forgot password page wrong css used to make it vertially aling middle

Description (*)

Fixed issue #20911 In admin login password forgot password page wrong css used to make it vertially aling middle

Fixed Issues (if relevant)

  1. magento/magento2 In admin login password forgot password page wrong css used to make it vertially aling middle  #20911: In admin login password forgot password page wrong css used to make it vertially aling middle

Manual testing scenarios (*)

  1. Open admin login page and click on forgot password link
    2.inspect on reload captcha button and view css on that button vertial-align: middle; used but will not work with float

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4113 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 12, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants