Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Inline block edit identifier validation #21376

Merged
merged 3 commits into from
Mar 25, 2019

Conversation

niravkrish
Copy link
Contributor

Description (*)

Dot is not allowed when editing CMS block in-line

Fixed Issues (if relevant)

  1. Dot is not allowed when editing CMS block in-line #21374: Dot is not allowed when editing CMS block in-line

Manual testing scenarios (*)

  1. Manual Testing

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Feb 21, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21376.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar self-assigned this Feb 21, 2019
@niravkrish
Copy link
Contributor Author

Hi @rogyar,
Please review and process this pull request.

@rogyar
Copy link
Contributor

rogyar commented Feb 26, 2019

Hi @niravkrish. We need to perform some internal checks regarding the frontend/backend validation. In short, we need to ensure that the absence of backend validation is a correct implementation

@niravkrish
Copy link
Contributor Author

Hi @rogyar,
Please review and process this pull request.

@rogyar
Copy link
Contributor

rogyar commented Mar 18, 2019

For QA.
I've just double checked the possibility to use CMS blocks identifiers with spaces in layout and other places (widgets). There's no need to have "xml-identifier" validation (we don't have it on the backend side anymore) since the additional characters are allowed and blocks with identifiers that contain spaces and other characters work without issues.

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4521 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Mar 21, 2019

✔️ QA Passed

Result:

after

@ghost
Copy link

ghost commented Mar 25, 2019

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants