Fixed WhiteSpace issue in product grid

[shrinet]

Fixes ##There are some whitespaces in between li tags, that's why product grid showing 3 products instead of 4. Mention in #20140 and #21244

Description (*)

Fixed Issues (if relevant)

#21244: Luma theme huge whitespace on category grid
#20140: Product per row not proper on listing page

Manual testing scenarios (*)

1. Please consider PR Fixed issue with lib-line-height mixin failing when value of 'normal'… #18168 before applying this as lib-line-height mixin still have normal issue

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @shrinet. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-4595 has been created to process this Pull Request

[magento-engcom-team]

@shrinet thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[shrinet]

I also recommend to revert PR #20168 as Its included in recent release.

[dmytro-ch]

These changes are overwritten by 2b47de7 commit.
So we don't need to revert them anymore.

[VasylShvorak]

Hi @shrinet I cannot reproduce issue #20140 on 2.3-develop.

[shrinet]

Hello @VasylShvorak yes I know it is not currently in 2.3-develop branch but it was in released version 2.3.0. However issue #20140 resolved in several merges from PR #20168 and #21582. But it seems in both approach was not as per code review recommendations. That's why I created new Pull Request.

Please let me know if any question.

[dmytro-ch]

That's right, the current PR is rather code refactoring that improves the already existing fix.

Thank you!

[VasylShvorak]

✔️ QA passed

[m2-assistant]

Hi @shrinet, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.