Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full Tax Summary display wrong numbers -Backport #21961

Merged
merged 4 commits into from
Apr 18, 2019
Merged

Full Tax Summary display wrong numbers -Backport #21961

merged 4 commits into from
Apr 18, 2019

Conversation

hiren0241
Copy link
Contributor

#20682

Description (*)

The full tax summary is displaying total tax, instead of showing individual tax value.

Fixed Issues (if relevant)

  1. Magento 2.3 Shopping Cart Taxes Missing Calc Line #19701: Magento 2.3 Shopping Cart Taxes Missing Calc Line
  2. Full Tax Summary display wrong numbers. #11358: Full Tax Summary display wrong numbers.

Manual testing scenarios (*)

  1. Manual Testing

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar self-assigned this Mar 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4625 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 9, 2019
@VasylShvorak
Copy link
Contributor

VasylShvorak commented Apr 9, 2019 •
edited
Loading

Hi @hiren0241 There are JS errors on the shopping cart page, can you please check it?
#20961

@hiren0241
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241, here is your new Magento instance.
Admin access: https://pr-21961.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@hiren0241
Copy link
Contributor Author

@VasylShvorak Please recheck now. I have resolve the error. I have tested my code on test instance as well. Everything is good now. Please do have a look at below screenshot as well.
PR21961

@hiren0241 hiren0241 requested a review from rogyar April 10, 2019 08:44
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4625 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this Apr 18, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 18, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit d417738 into magento:2.2-develop Apr 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @hiren0241, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 18, 2019
@sivaschenko
ENGCOM-4625: Full Tax Summary display wrong numbers -Backport #21961
3ebbff1
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Area: Frontend Component: Tax Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.
6 participants
@hiren0241 @magento-engcom-team @VasylShvorak @rogyar @sdzhepa @p-bystritsky