BeanShells are changed to correct using of variables

[AnnaShepa]

Description (*)
In loops to collect products in SetUp thread added variable declaration to avoid 500 error. As well as changed using of wrong variable in collection products for edit.

Manual testing scenarios (*)

Run the SetUp thread - as the result jMeter return no 500 error "org.apache.jorphan.util.JMeterException: Error invoking bsh method: eval"

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[m2-assistant]

Hi @AnnaShepa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

Please leave only meaningful changes.

[AnnaShepa]

@orlangur formatting updated

[orlangur]

@AnnaShepa thanks! Changes looks good to me.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

[AnnaShepa]

@orlangur done, squashed

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-4680 has been created to process this Pull Request

[magento-engcom-team]

@AnnaShepa thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[sivaschenko]

Performance tests are failing on the validation stage with the following message:

Any changes to the Performance Toolkit JMeter script (setup/performance-toolkit/benchmark.jmx), must be made in the jmx generator fragments (magento2-infrastructure/build/core_dev/performance/mpaf/tool/fragments). The final version of the Performance Toolkit JMeter script (setup/performance-toolkit/benchmark.jmx) must be generated from fragments via perf.php (read documentation from magento2-infrastructure/build/core_dev/performance/mpaf/README.md)

@p-bystritsky could you please help to resolve this.

[sidolov]

Hi @p-bystritsky , performance build still failing due to scenario inconsistency. Could you please take a look?

[sivaschenko]

Performance Acceptance Tests are failing at the CE and B2B validation stage (passing for EE)

@p-bystritsky please check the error message, feel free contact me for any questions

Any changes to the Performance Toolkit JMeter script (setup/performance-toolkit/benchmark.jmx), 
must be made in the jmx generator fragments (magento2- 
infrastructure/build/core_dev/performance/mpaf/tool/fragments).         The final version of the 
Performance Toolkit JMeter script (setup/performance-toolkit/benchmark.jmx) must be generated 
from fragments via perf.php (read documentation from magento2- 
infrastructure/build/core_dev/performance/mpaf/README.md)

[m2-assistant]

Hi @AnnaShepa, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.