Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all marketing get params on Varnish to minimize the cache objects (added facebook and bronto parameter) #22226

Conversation

lfluvisotto
Copy link
Contributor

Description (*)

Right now the same page with different UTM, mailchimp, other marketing params is NOT cached. It leads to higher load than expected.
This PR removes marketing get params from URL, as result - increased returned results from cache -> Lower load on servers.

Related: https://stackoverflow.com/questions/45298422/seo-and-stripping-utm-parameters-with-varnish

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Go to URL: http://magento2.local/?fbclid=campaign1 (FPC should be MISS)
  2. Go to URL: http://magento2.local/?fbclid=campaign1 (FPC should be HIT)
  3. Go to URL: http://magento2.local/?fbclid=campaign2 (FPC should be HIT)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 8, 2019

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4707 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

Copy link
Contributor

@kalpmehta kalpmehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please exclude Bronto email params (_bta_tid, _bta_c) as well? Appreciate it!

@lfluvisotto lfluvisotto changed the title Remove all marketing get params on Varnish to minimize the cache objects (added facebook parameter) Remove all marketing get params on Varnish to minimize the cache objects (added facebook and bronto parameter) Apr 16, 2019
Copy link
Contributor

@kalpmehta kalpmehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-4707 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2019

Hi @lfluvisotto, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants