Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Remove all marketing get params on Varnish to minimize the cache objects #22216

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Apr 8, 2019

Original Pull Request

#21818

Description (*)

Right now the same page with different UTM, mailchimp, other marketing params is NOT cached. It leads to higher load than expected.
This PR removes marketing get params from URL, as result - increased returned results from cache -> Lower load on servers.

Related: https://stackoverflow.com/questions/45298422/seo-and-stripping-utm-parameters-with-varnish

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Go to URL: http://magento2.local/?utm_campaign=campaign1 (FPC should be MISS)
  2. Go to URL: http://magento2.local/?utm_campaign=campaign1 (FPC should be HIT)
  3. Go to URL: http://magento2.local/?utm_campaign=campaign2 (FPC should be HIT)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 8, 2019

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@lfluvisotto
Copy link
Contributor

lfluvisotto commented Apr 8, 2019

@ihor-sviziev how about also add fbclid (facebook parameter) in a new pull request ?

@lfluvisotto
Copy link
Contributor

@ihor-sviziev please check it #22226

@ihor-sviziev
Copy link
Contributor Author

Duplicate of #21819

@ihor-sviziev ihor-sviziev marked this as a duplicate of #21819 Apr 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 8, 2019

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev ihor-sviziev deleted the 2.2-develop-PR-port-21818 branch April 8, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants