Shortening currency list in Configuration->General (replace PR #20397) #22230

melaxon · 2019-04-08T23:46:02Z

Description (*)

in Store->Configuration->General->Currency setup will be shown only those currencies selected in
Installed currencies list (Configuration->Advanced->System)

This filters the list of allowed currencies to show only selected ones

This PR replaces closed one #19946

Fixed Issues (if relevant)

magento/magento2#<issue_number>: Issue title
...

Manual testing scenarios (*)

The list of currencies will look like in screenshot
These changes can be applied to 2.2.x as well

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

m2-assistant · 2019-04-08T23:46:04Z

Hi @melaxon. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

ghost · 2019-04-08T23:51:41Z

@melaxon unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

orlangur · 2019-04-09T06:38:24Z

app/code/Magento/Config/Model/Config/Source/Locale/Currency.php

+        $options = array_filter(
+            $this->_options,
+            function ($option) use ($selected) {
+                return in_array($option['value'], $selected);


Please flip array so that we can check with isset.

Please array so that we can check with isset.

Hi orlangur!
Please take a look if this is what you mean:
de3d22e

That's okay if all currency codes are 3 latin characters. If one day some exotic currency will be used this checking may fail. Taking into account that this operation is not really time critical (it works only for admin) I would leave it as it was

@melaxon,

If one day some exotic currency will be used this checking may fail

I don't see how it can fail, also, 3 letters is an ISO standard.

No need in filling keys, just use array_flip.

..., just use array_flip.

Done: 2d9465c

orlangur

Please squash changes into a single commit so that we have perfectly clean history 😉

melaxon · 2019-04-10T08:21:06Z

Please squash changes into a single commit so that we have perfectly clean history 😉

Done (I think)

magento-engcom-team · 2019-04-11T08:29:33Z

Hi @aleron75, thank you for the review.
ENGCOM-4736 has been created to process this Pull Request

VasylShvorak · 2019-04-16T08:41:43Z

✔️ QA passed

orlangur

@melaxon nope, I still see 5 commits here.

use isset array_flip

melaxon · 2019-04-20T16:58:02Z

@melaxon nope, I still see 5 commits here.

Sorry for the delay. I squashed the commits

magento-engcom-team · 2019-04-21T21:13:40Z

Hi @orlangur, thank you for the review.
ENGCOM-4736 has been created to process this Pull Request

VasylShvorak · 2019-04-22T11:03:09Z

✔️ QA passed

sivaschenko · 2019-04-23T11:02:57Z

@paliarush can you please take a look at this pull request - a new optional constructor argument is added to API class

paliarush · 2019-04-23T14:10:29Z

SVC failure due to optional argument in constructor approved.

m2-assistant · 2019-04-29T14:07:02Z

Hi @melaxon, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…ace PR #20397) #22230

magento-engcom-team added Component: Config Release Line: 2.3 labels Apr 8, 2019

melaxon mentioned this pull request Apr 8, 2019

Shortening currency list in Configuration->General (this replaces PR #19946) #20397

Closed

4 tasks

melaxon requested review from orlangur and aleron75 April 8, 2019 23:49

melaxon assigned orlangur Apr 8, 2019

ghost unassigned orlangur Apr 8, 2019

orlangur requested changes Apr 9, 2019

View reviewed changes

ghost assigned orlangur Apr 9, 2019

ghost added the Progress: needs update label Apr 9, 2019

orlangur requested changes Apr 9, 2019

View reviewed changes

aleron75 approved these changes Apr 11, 2019

View reviewed changes

ghost assigned aleron75 Apr 11, 2019

ghost added Progress: ready for testing and removed Progress: needs update labels Apr 11, 2019

VasylShvorak self-assigned this Apr 16, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Apr 16, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Apr 16, 2019

orlangur requested changes Apr 16, 2019

View reviewed changes

ghost added Progress: needs update and removed Progress: extended testing labels Apr 16, 2019

melaxon force-pushed the currency_list branch from a6e32bc to 2d9465c Compare April 20, 2019 16:47

Shortening currency list in Configuration->General

0c1ffcd

use isset array_flip

melaxon force-pushed the currency_list branch from 2d9465c to 0c1ffcd Compare April 20, 2019 16:55

orlangur approved these changes Apr 21, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Apr 21, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Apr 22, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Apr 22, 2019

nmalevanec self-assigned this Apr 22, 2019

ghost added Progress: accept and removed Progress: extended testing labels Apr 22, 2019

magento-engcom-team added the Award: bug fix label Apr 23, 2019

magento-engcom-team merged commit 0c1ffcd into magento:2.3-develop Apr 29, 2019

magento-engcom-team pushed a commit that referenced this pull request Apr 29, 2019

ENGCOM-4736: Shortening currency list in Configuration->General (repl…

5c7ecce

…ace PR #20397) #22230

magento-engcom-team added this to the Release: 2.3.2 milestone Apr 29, 2019

melaxon deleted the currency_list branch April 29, 2019 14:26

melaxon restored the currency_list branch April 29, 2019 14:27

melaxon deleted the currency_list branch April 29, 2019 14:33

amol2jcommerce mentioned this pull request Apr 30, 2019

[Backport] Shortening currency list in Configuration->General (replace PR #20397) #22551

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shortening currency list in Configuration->General (replace PR #20397) #22230

Shortening currency list in Configuration->General (replace PR #20397) #22230

melaxon commented Apr 8, 2019

m2-assistant bot commented Apr 8, 2019

ghost commented Apr 8, 2019

orlangur Apr 9, 2019 •

edited

Loading

melaxon Apr 9, 2019 •

edited

Loading

orlangur Apr 9, 2019

melaxon Apr 9, 2019

orlangur left a comment

melaxon commented Apr 10, 2019

magento-engcom-team commented Apr 11, 2019

VasylShvorak commented Apr 16, 2019

orlangur left a comment

melaxon commented Apr 20, 2019

magento-engcom-team commented Apr 21, 2019

VasylShvorak commented Apr 22, 2019

sivaschenko commented Apr 23, 2019

paliarush commented Apr 23, 2019

m2-assistant bot commented Apr 29, 2019

Shortening currency list in Configuration->General (replace PR #20397) #22230

Shortening currency list in Configuration->General (replace PR #20397) #22230

Conversation

melaxon commented Apr 8, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

m2-assistant bot commented Apr 8, 2019

ghost commented Apr 8, 2019

orlangur Apr 9, 2019 • edited Loading

Choose a reason for hiding this comment

melaxon Apr 9, 2019 • edited Loading

Choose a reason for hiding this comment

orlangur Apr 9, 2019

Choose a reason for hiding this comment

melaxon Apr 9, 2019

Choose a reason for hiding this comment

orlangur left a comment

Choose a reason for hiding this comment

melaxon commented Apr 10, 2019

magento-engcom-team commented Apr 11, 2019

VasylShvorak commented Apr 16, 2019

orlangur left a comment

Choose a reason for hiding this comment

melaxon commented Apr 20, 2019

magento-engcom-team commented Apr 21, 2019

VasylShvorak commented Apr 22, 2019

sivaschenko commented Apr 23, 2019

paliarush commented Apr 23, 2019

m2-assistant bot commented Apr 29, 2019

orlangur Apr 9, 2019 •

edited

Loading

melaxon Apr 9, 2019 •

edited

Loading