Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter config values on testSuiteStart #22415

Merged
merged 1 commit into from
Apr 25, 2019
Merged

filter config values on testSuiteStart #22415

merged 1 commit into from
Apr 25, 2019

Conversation

bcerban
Copy link
Contributor

@bcerban bcerban commented Apr 18, 2019

Description (*)

Fixed Issues (if relevant)

  1. Filtering ignored config values in test framework causes error #22370: Filtering ignored config values in test framework causes error

Manual testing scenarios (*)

  1. Set compiled_config => 1 in app/etc/env.php cache types.
  2. Then run the integration test suite.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @bcerban. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

aleron75
aleron75 reviewed Apr 23, 2019
View reviewed changes
dev/tests/integration/framework/Magento/TestFramework/Isolation/DeploymentConfig.php
@@ -51,7 +51,7 @@ public function startTestSuite()
{
if (null === $this->reader) {
$this->reader = Bootstrap::getObjectManager()->get(\Magento\Framework\App\DeploymentConfig\Reader::class);
$this->config = $this->reader->load();
$this->config = $this->filterIgnoredConfigValues($this->reader->load());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, maybe I'm missing something but where the filterIgnoredConfigValues() method comes from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aleron75 it's on line 90 in that same file. It is only available on the 2.2 releases, and was included in version 2.2.8.

@aleron75 aleron75 self-assigned this Apr 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-4814 has been created to process this Pull Request

@soleksii soleksii self-assigned this Apr 24, 2019
@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@ghost ghost removed the Progress: accept label Apr 24, 2019
@ghost ghost added the Progress: accept label Apr 25, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 25, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 79e90ba into magento:2.2-develop Apr 25, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 25, 2019

Hi @bcerban, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 25, 2019
@sidolov
ENGCOM-4814: filter config values on testSuiteStart #22415
0220d6d
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 25, 2019
@bcerban bcerban deleted the issue-22370-2.2 branch April 25, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 approved these changes

Assignees

@aleron75 aleron75

@soleksii soleksii

Labels
Award: bug fix Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.
5 participants
@bcerban @magento-engcom-team @soleksii @aleron75 @sivaschenko