Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13689 - category url key accept all language including special characters #22652

Conversation

pradeep-wagento
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Cannot create catagory's name with thai langauge #13689: Cannot create catagory's name with thai langauge

Manual testing scenarios (*)

  1. Create Category with Special Character String for e.g สินค้าขายดี

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @pradeep-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 4, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Component: Filter Release Line: 2.3 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels May 4, 2019
@orlangur orlangur self-assigned this May 4, 2019
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such change is backward incompatible. New behavior should be implemented separately and be turned off by default at least in patch releases. Please prepare a proposal to https://github.com/magento/architecture covering all the details - indexing, routing etc.

@sidolov
Copy link
Contributor

sidolov commented May 22, 2019

@pradeep-wagento , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this May 22, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 22, 2019

Hi @pradeep-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Filter Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants