Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/inconsistent test names #22853

Closed
wants to merge 15 commits into from
Closed

Fix/inconsistent test names #22853

wants to merge 15 commits into from

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

Extracted the Tests that were coupled several in one file to separate files.

Fixed Issues (if relevant)

Not applicable

Manual testing scenarios (*)

  1. vendor/bin/mftf generate:tests
  2. Enjoy!

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 12, 2019

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@peterlohaus
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @peterlohaus. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @peterlohaus, here is your Magento instance.
Admin access: https://i-22853-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@lbajsarowicz
Merge remote-tracking branch 'origin/2.3-develop' into fix/inconsiste…
4ed91ab 
…nt-test-names

# Conflicts:
#	app/code/Magento/Checkout/Test/Mftf/Test/CheckCheckoutSuccessPageAsRegisterCustomer.xml
@lbajsarowicz
Merge of latest 2.3-develop
07dbf7a
@dmytro-ch
Copy link
Contributor

dmytro-ch commented May 27, 2019 •
edited

Hi @lbajsarowicz,
thank you for your contribution!

Please note, the MFTF tests improvements should be provided in the scope of magento/magento-functional-tests-migration repository.
Could you please move the current pull request to the MFTF project?

The current pull request will be closed.

CC: @okolesnyk

@dmytro-ch dmytro-ch self-assigned this May 27, 2019
@lbajsarowicz
Copy link
Contributor Author

IMHO This is change to tests coupled with modules, not MFTF itself. If it was related with Testing Framework, I would apply changes to MFTF repository.

@okolesnyk
Copy link
Member

Hi @dmytro-ch

Currently we require to move PRs to magento/magento-functional-tests-migration only if they are related to MTF tests conversion.

Changes related to existing MFTF test should go to magento/magento2 repo.

@ghost ghost added the Progress: on hold label Jun 4, 2019
@ghost
Copy link

ghost commented Jun 4, 2019

@okolesnyk unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

Łukasz Bajsarowicz added 2 commits June 11, 2019 11:45
Merge remote-tracking branch 'origin/2.3-develop' into fix/inconsiste…
8e467d5 
…nt-test-names

# Conflicts:
#	app/code/Magento/Captcha/Test/Mftf/Test/CaptchaFormsDisplayingTest.xml
#	app/code/Magento/Checkout/Test/Mftf/Test/StorefrontCustomerCheckoutTest.xml
#	app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminConfigurableProductUpdateTest.xml
#	app/code/Magento/Customer/Test/Mftf/Test/ChangingSingleCustomerGroupViaGrid.xml
#	app/code/Magento/Tax/Test/Mftf/Test/StorefrontTaxQuoteCartTest.xml
Apply changes from recent 2.3-develop
5714372
@lbajsarowicz
Copy link
Contributor Author

@okolesnyk Rebased to latest 2.3-develop

@dmytro-ch
Copy link
Contributor

Hi @okolesnyk, thank you for the details! :)

This was referenced Nov 28, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 9, 2020
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko requested changes

@okolesnyk okolesnyk okolesnyk approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@akaplya akaplya Awaiting requested review from akaplya

@kokoc kokoc Awaiting requested review from kokoc

@melnikovi melnikovi Awaiting requested review from melnikovi

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@sivaschenko sivaschenko

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: MFTF test coverage Component: Bundle Component: Captcha Component: Catalog Partner: Strix partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@lbajsarowicz @peterlohaus @magento-engcom-team @dmytro-ch @okolesnyk @soleksii @engcom-Alfa @sivaschenko @engcom-Foxtrot @ysapiga