-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Extract Action Groups to separate files - magento/module-currency-symbol #25829
MFTF: Extract Action Groups to separate files - magento/module-currency-symbol #25829
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@@ -17,13 +17,4 @@ | |||
<click selector="{{StorefrontSwitchCurrencyRatesSection.currency(currency)}}" stepKey="chooseCurrency"/> | |||
<see selector="{{StorefrontSwitchCurrencyRatesSection.selectedCurrency}}" userInput="{{currency}}" stepKey="seeSelectedCurrency"/> | |||
</actionGroup> | |||
<actionGroup name="StorefrontSwitchCurrency"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch here :)
It looks like the result of incorrect merge conflict resolving.
I guess we can also remove currencyTrigger
element from StorefrontSwitchCurrencyRatesSection
section, to avoid duplicates and misunderstandings in the future. @lbajsarowicz what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed that to avoid confusion.
I'll review all the sections soon during other Contribution Days :-)
Hi @dmytro-ch, thank you for the review.
|
✔️ QA Passed |
@okolesnyk / @okorshenko / @dmytro-ch / @VladimirZaets Dear Maintainers, due to your concerns about backward compatibility, I provided the Hope that will let you merge that sooner than with |
Hi @dmytro-ch, thank you for the review. |
…module-currency-symbol #25829
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
Extract each Action Group to separate file, to follow MFTF Best Practices.
Fixed Issues (if relevant)
Questions or comments
Had to extract the changes per-module. The previous try failed, because of conflicts.
Contribution checklist (*)