Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Tierprice can t save float percentage value 18651 #22936

Merged

Conversation

novikor
Copy link
Contributor

@novikor novikor commented May 18, 2019

Original Pull Request

#19584

Description (*)

See #18651

Fixed Issues (if relevant)

  1. Tierprice can't save float percentage value #18651: Tierprice can't save float percentage value

Manual testing scenarios (*)

Steps to reproduce (*)

  1. Add new product
  2. Add new tierprice with "discount" value "12.5"
  3. Save the product

Expected result (*)

  1. Saving the tierprice as you set it "12.5"

Actual result (*)

  1. It's converted to INT then save it

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@novikor novikor force-pushed the 2.2-develop-PR-port-19584 branch from b55fda0 to 53aff60 Compare May 18, 2019 13:10
@m2-assistant
Copy link

m2-assistant bot commented May 18, 2019

Hi @novikor. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Catalog Release Line: 2.2 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels May 18, 2019
@rogyar rogyar self-assigned this May 18, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5132 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Result:

after

@ghost ghost assigned orlangur May 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5132 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented May 21, 2019

Hi @novikor, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone May 21, 2019
@novikor novikor deleted the 2.2-develop-PR-port-19584 branch May 22, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants