Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the contributing.md to match the new beginners guide #22951

Merged

Conversation

dmanners
Copy link
Contributor

Description (*)

The aim of this pull request is to update the following files to make them more useful to people.

  • contributing.md
  • issue_template.md
  • pull_request_template.md

Questions and thoughts

  • Should the contributing.md have more information from the beginners guides or is it ok just to link in but leave the information as is?
  • After a bit of feedback and usage I can see that the issue and pull request templates are not too clear. I have removed some lines that I think are not needed and also added a new section for open questions as a few people have asked if it was ok to ask question on a PR you are writing.

I would be happy for any further thoughts or input on these changes.

@m2-assistant
Copy link

m2-assistant bot commented May 20, 2019

Hi @dmanners. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, thank you for the review.
ENGCOM-5137 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

Notice: QA not applicable

@p-bystritsky p-bystritsky self-assigned this May 21, 2019
@okorshenko okorshenko changed the title [WIP] Update the contributing.md to match the new beginners guide Update the contributing.md to match the new beginners guide May 21, 2019
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 24, 2019
@magento-engcom-team magento-engcom-team merged commit d763972 into magento:2.3-develop May 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 24, 2019

Hi @dmanners, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants