Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed issue #22639: Without select attribute click on add attribute it display all selected when add attribute again. #22991

Conversation

mahesh-rajawat
Copy link
Member

Original Pull Request

#22724

Fixed issue #22639 in this PR.

Description (*)

Without select attribute click on add attribute it display all selected when add attribute again.
this issue fixed in this PR.

Fixed Issues (if relevant)

  1. Without select attribute click on add attribute it display all selected when add attribute again. #22639
  2. ...

Manual testing scenarios (*)

  1. Go to Admin
  2. Catalog >> Products >> Add New Product
  3. Click on Add Attribute button
  4. Without select any attribute click on add selected
  5. It will close the popup window
  6. Now click Add Attribute again
  7. No attributes are selected now.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 23, 2019

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5149 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this May 24, 2019
@Nazar65 Nazar65 self-assigned this May 24, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented May 24, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 24, 2019
…click on add attribute it display all selected when add attribute again. #22991
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants