Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Customer Account Forgot Password page title fix #23148

Conversation

krishprakash
Copy link

Original Pull Request

#22821
Missing question mark in Customer Account Forgot Password page title, because of this it was missing the translated string.

@m2-assistant
Copy link

m2-assistant bot commented Jun 6, 2019

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 6, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Prakash Prajapati seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@VasylShvorak
Copy link
Contributor

✔️ QA passed

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishprakash original commit author and message must be preserved

Missing question mark in Customer Account Forgot Password page title
@krishprakash
Copy link
Author

@orlangur I have updated the PR as suggested by you.
Please have a look and update the PR.
Thank you.

@soleksii
Copy link

✔️ QA Passed

@ysapiga ysapiga self-assigned this Jun 10, 2019
@magento-engcom-team magento-engcom-team merged commit 851bf23 into magento:2.2-develop Jun 11, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 11, 2019

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants