Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external links to the Magento technical documentation #24036

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Fix external links to the Magento technical documentation #24036

merged 3 commits into from
Aug 14, 2019

Conversation

dshevtsov
Copy link
Contributor

Description (*)

Fix broken links and update obsolete links to devdocs.magento.com and docs.magento.com domains.

Manual testing scenarios (*)

  1. Click a link to devdocs.magento.com or docs.magento.com domains
  2. The requested HTML page is successfully rendered with no errors
  3. The page is of latest version of the topic (2.3)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Fix links to devdocs.magento.com and docs.magento.com
@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2019

Hi @dshevtsov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 6, 2019

CLA assistant check
All committers have signed the CLA.

@hostep
Copy link
Contributor

hostep commented Aug 6, 2019

@dshevtsov: wouldn't it make more sense to have some sort of latest part in the url on devdocs instead of a fixed version number which will change every year or so?
I already suggested something like that a while ago: magento/devdocs#924 (comment)

@dshevtsov
Copy link
Contributor Author

@hostep yes, it would, for sure. This is in the DevDocs team roadmap and we've been discussing different ways of how to get closer to this.

@ghost ghost assigned rogyar Aug 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5553 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 14, 2019
@magento-engcom-team magento-engcom-team merged commit becb0e0 into magento:2.3-develop Aug 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 14, 2019

Hi @dshevtsov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 14, 2019
@dshevtsov dshevtsov mentioned this pull request Aug 21, 2019
4 tasks
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: multiple Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants