Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Spacing issue in grid #24359

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Fixed the Spacing issue in grid #24359

merged 1 commit into from
Sep 7, 2019

Conversation

Nagamaiah007
Copy link
Contributor

Fixed the Spacing issue in grid

Description (*)

Fixed Issues (if relevant)

  1. Spacing Issue with the Admin grids pages #24152: Spacing Issue with the Admin grid pages

Manual testing scenarios (*)

  1. Open Magento Admin Navigate to any page which has grid inside it (Ex Customer).
  2. Now we can see spacing between the page limiter drop down and text "per page" is as per Magento Standards as shown in the provided screenshot.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Fixed the Spacing issue in grid
@m2-assistant
Copy link

m2-assistant bot commented Aug 29, 2019

Hi @Nagamaiah333. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 29, 2019

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link

ghost commented Aug 29, 2019

@Nagamaiah333 unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@ghost ghost assigned engcom-Foxtrot Sep 3, 2019
@magento-engcom-team
Copy link
Contributor

@Nagamaiah333 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@magento-engcom-team magento-engcom-team merged commit 785cdcd into magento:2.3-develop Sep 7, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2019

Hi @Nagamaiah333, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 7, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: i95Dev partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants