Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Add Review" if System has no Product issue24310 #24399

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Remove "Add Review" if System has no Product issue24310 #24399

merged 1 commit into from
Sep 7, 2019

Conversation

edenduong
Copy link
Contributor

Description (*)

If Magento has no Product, add Review button should be invisible.

Fixed Issues (if relevant)

  1. New Review form is redirected to review grid #24310: New Review form is redirected to review grid

Manual testing scenarios (*)

Magento instance doesn't have any products

  1. Go to Admin
  2. Marketing -> All Reviews -> New Review
  3. Click on add new review

Expected result

Add review button should not be visible in the grid

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 1, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Stepa4man
Stepa4man requested changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edenduong Thanks, for your contribution.

Please check my comments.

app/code/Magento/Review/Block/Adminhtml/Main.php Outdated Show resolved Hide resolved
app/code/Magento/Review/Block/Adminhtml/Main.php Outdated Show resolved Hide resolved
app/code/Magento/Review/Block/Adminhtml/Main.php Outdated Show resolved Hide resolved
@ghost ghost assigned Stepa4man Sep 2, 2019
@edenduong
Copy link
Contributor Author

Hi @edenduong Thanks, for your contribution.

Please check my comments.

Hi @Stepa4man :

Thank you for your reviewing. Sorry for the mistakes. I have changed the source code. Please check it again.

Have a nice day!

@Stepa4man
Copy link
Contributor

@edenduong could you please check tests?

@edenduong
Copy link
Contributor Author

@edenduong could you please check tests?

I have fixed the Unit Test issue. Please check it again. Thanks @Stepa4man :)

@edenduong edenduong force-pushed the 2.3-bugfix/remove_add_if_no_product_issue24310 branch from e082843 to 38cf8d6 Compare September 3, 2019 15:00
@ghost ghost assigned sidolov Sep 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5774 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Sep 5, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Sep 6, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Sep 7, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Sep 7, 2019
@sidolov
ENGCOM-5774: Remove "Add Review" if System has no Product issue24310 #…
121caa9 
…24399
@magento-engcom-team magento-engcom-team merged commit 38cf8d6 into magento:2.3-develop Sep 7, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 7, 2019
@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stepa4man Stepa4man Stepa4man requested changes

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

@Stepa4man Stepa4man

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Review Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@edenduong @Stepa4man @magento-engcom-team @engcom-Delta @sidolov @engcom-Foxtrot