Performance optimizations

[andrey-legayev]

Description (*)

I've prepared several performance optimizations based on my XDebug profiling and debugging of add to cart process and shopping cart page.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

General regression testing

Questions or comments

N/A

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @andrey-legayev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[andrey-legayev]

Can someone help me to fix following findings of Static Tests?

1. I didn't change this part and I don't think I should:

FILE: ...ml/lib/internal/Magento/Framework/View/Element/AbstractBlock.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
  19 | WARNING | Abstract classes MUST NOT be marked as public @api.
 248 | WARNING | Empty FUNCTION statement detected

2. There is {inheritdoc} instruction - isn't it valid?

FILE: ...al/Magento/Framework/App/ObjectManager/ConfigLoader/Compiled.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 29 | ERROR | [x] Missing @param for argument in method annotation

[andrey-legayev]

I've tested: str_replace() is slower than strtr() in this case

[andrey-legayev]

Static tests have been fixed.
@ihor-sviziev - thank you!

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6126 has been created to process this Pull Request

[andrey-legayev]

I've run performance tests for string concat vs. array join:
https://gist.github.com/andrey-legayev/24ed101a34d4775bf1b6f9879581f51a

No real performance improvement (which surprised me).
But anyway - I'm rolling back string concatenation improvements, because it doesn't make any sense.

[slavvka]

@engcom-Foxtrot please take a look at static tests and seems like some EE and B2B are failing as well

[engcom-Golf]

Hi @andrey-legayev Please fix failed static test and Functional Test, as we have no access to your repository, thank you!

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6126 has been created to process this Pull Request

[m2-assistant]

Hi @andrey-legayev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.