Fixes issue 23411 - Remove misplaced critical log "No such entity with customerId = xx"

[hostep]

Description (*)

This is a new attempt at fixing #23411, this is based on #23952

Review comments from @ihor-sviziev have been taken into account.
The removal of the comment above the constant CHECKOUT_STATE_BEGIN was done to satisfy Magento's coding standard checks, it added no useful information.

Fixed Issues (if relevant)

1. After upgrading to new version - No such entity with customerId critical logs #23411: After upgrading to new version - No such entity with customerId critical logs
2. New Quote is not creating after order place for logged in customer #24009: New Quote is not creating after order place for logged in customer

Manual testing scenarios (*)

See: #23952 or #23411 (comment)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @hostep. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[hostep]

Pushed one final change: $this->setQuoteId($quote->getId()); => $this->setQuoteId($quoteByCustomer->getId());

This caused some functional test to fail, has something to do with persistent sessions.
All tests should be green now hopefully :)

[ihor-sviziev]

Hi @hostep,
Changes looks good.
Would be great to cover your changes with some test. Will you be able to do that?

[hostep]

Hi @ihor-sviziev

What kind of test did you have in mind?

Honestly I have not that much deep knowledge about this part of the Magento codebase.
The intention of this PR is just to try to get that highly annoying/distracting false log message out of the exception.log file :)

[ihor-sviziev]

Hi @hostep,
Just analyzed - looks like cover this change with test will be too hard. I’m approving this PR without tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6185 has been created to process this Pull Request

[engcom-Bravo]

Hello @hostep. Thank You for Your contribution. Would You please cover Your PR with the appropriate Auto-Tests.

[hostep]

@engcom-Bravo: can you clarify what you would like to see tested? Thanks! 🙂

[hostep]

Did some cleanup, will attempt to take a look at adding a new integration test as requested next.

[hostep]

Hi @ihor-sviziev, @engcom-Bravo or @engcom-Foxtrot

Can one of you guys take care of this required integration test you are asking for?
After looking for more than an hour on how to approach this and trying out some things, I still don't see it and I won't have anymore time/energy to keep searching. Writing tests is not my forté, so I would be appreciated if one of you (or somebody else) can take this over.

Thanks and sorry!

[engcom-Bravo]

✔️ QA Passed.

[m2-assistant]

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[hostep]

Thanks for adding a test @Nazar65 ! 🙂