Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing input phone type to tel in Contact, Error Report and Customer widget pages #25321

Merged

Conversation

rafaelstz
Copy link
Member

@rafaelstz rafaelstz commented Oct 27, 2019

Description (*)

I changed the phone input type from text to tel, it improves a lot the user experience. As it was applied in the email input, the field type email is in use already.

Screen Shot 2019-10-27 at 12 18 15 PM

It will show like this image below.

Screen Shot 2019-10-27 at 12 16 38 PM

Manual testing scenarios (*)

Contact Page

  1. Accessing the contact form in a mobile device and clicking on the phone field.

Error Report

  1. Generate some error in production mode the contact form in a mobile device

Customer Widget

  1. Accessing the customer form in a mobile device and clicking on the phone field.

Comments (*)

This feature has high compatibility, but if it's opened in a browser without compatibility, the browsers fallback is returning it to text type.

Screen Shot 2019-10-27 at 12 31 37 PM

Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/tel

Related PRs:
#25322
#25323

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2019

Hi @rafaelstz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rodrigowebjump
Copy link
Member

Hi @rafaelstz

I will discuss internally this change since it can make some in place customizations incompatibles

@rodrigowebjump rodrigowebjump self-assigned this Oct 28, 2019
@rafaelstz
Copy link
Member Author

ok @rodrigowebjump
Thanks

@davidalger davidalger removed their request for review October 28, 2019 15:26
@rodrigowebjump
Copy link
Member

@magento combine 25322 25323

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump. Thank you for your request. I'm working on combining the pull requests for you

@magento-engcom-team
Copy link
Contributor

@rafaelstz all pull requests have been successfully combined together:

@rodrigowebjump rodrigowebjump changed the title Contact Page > Changing input phone type to tel Changing input phone type to tel in Contact, Error Report and Customer widget pages Oct 31, 2019
@rodrigowebjump
Copy link
Member

@magento give me test instance

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 26, 2019
@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:17
@ihor-sviziev ihor-sviziev self-assigned this Feb 14, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6915 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Delta, here is your new Magento instance.
Admin access: https://pr-25321.instances.magento-community.engineering/admin_24c6
Login: 4641b150 Password: 81762d4fef32
Instance will be terminated in up to 3 hours.

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Charlie engcom-Charlie self-assigned this Feb 18, 2020
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Feb 18, 2020
magento-engcom-team pushed a commit that referenced this pull request Feb 21, 2020
@magento-engcom-team magento-engcom-team merged commit bb8f1ee into magento:2.4-develop Feb 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2020

Hi @rafaelstz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants