Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer Widget > Changing input phone type to tel #25322

Closed

Conversation

rafaelstz
Copy link
Member

@rafaelstz rafaelstz commented Oct 27, 2019

Description (*)

I changed the phone input type from text to tel, it improves a lot the user experience. As it was applied in the email input, the field type email is in use already.

Screen Shot 2019-10-27 at 12 18 15 PM

It will show like this image below.

Screen Shot 2019-10-27 at 12 16 38 PM

Manual testing scenarios (*)

  1. Accessing the form in a mobile device and clicking on the phone field.

Comments (*)

This feature has high compatibility, but if it's opened in a browser without compatibility, the browsers fallback is returning it to text type.

Screen Shot 2019-10-27 at 12 31 37 PM

Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/tel

Related PRs:
#25321
#25323

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2019

Hi @rafaelstz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rodrigowebjump
Copy link
Member

Hi @rafaelstz

I will discuss internally this change since it can make some in place customizations incompatibles

@rodrigowebjump rodrigowebjump self-assigned this Oct 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rafaelstz
Thank you for your contribution. This pull request has been combined (merged) with #25321 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

@m2-assistant
Copy link

m2-assistant bot commented Oct 31, 2019

Hi @rafaelstz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added a commit to rafaelstz/magento2 that referenced this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants