Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete code which doesn't have any sense here #25770

Merged

Conversation

AndreyChorniy
Copy link
Contributor

Description (*)

This PR delete unused code from template Magento/Catalog/view/frontend/templates/product/listing.phtml

Fixed Issues (if relevant)

  1. Product listing time taken profiling dump #25715: Product listing time taken profiling dump

Manual testing scenarios (*)

  1. Go to the category page (it should load properly, without issues)
  2. Go to the search result page (it should load properly, without issues)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 27, 2019

Hi @AndreyChorniy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Catalog Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 27, 2019
@AndreyChorniy AndreyChorniy added Partner: Atwix Pull Request is created by partner Atwix and removed Partner: Atwix Pull Request is created by partner Atwix labels Nov 27, 2019
@rogyar rogyar self-assigned this Nov 27, 2019
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6345 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@AndreyChorniy thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed.

Copy link
Contributor

@krzksz krzksz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my optinion this commit violates the following point of Contribution Requirements:

  1. Commits must be accompanied by meaningful commit messages.

@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 2, 2019
@magento-engcom-team magento-engcom-team merged commit ed92b99 into magento:2.3-develop Dec 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 3, 2019

Hi @AndreyChorniy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants