Category filters - Fix notice on incorrect price param

[ihor-sviziev]

Description (*)

See details in #25911

Fixed Issues (if relevant)

1. Category - Notice on incorrect price filter GET param #25911 : Category - Notice on incorrect price filter GET param

Manual testing scenarios (*)

1. See details in Category - Notice on incorrect price filter GET param #25911

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @krzksz, thank you for the review.
ENGCOM-6424 has been created to process this Pull Request

[engcom-Bravo]

Hello @ihor-sviziev. Thank You for Your contribution. Would You please take a look at the following gif:

The system.log also does not contain any main.criticals. So it is that ether the issue this PR is going to fix is not reproduced on 2.4-develop or we miss or misunderstand something when trying to reproduce it. If the true one is the second please help us to reproduce it. Thank You.

[engcom-Bravo]

@ihor-sviziev, we have immediately found the cause we were not able to reproduce the issue. In order to have it reproduced "for instance https://example.com/my-category/?price=-100%27[0]" should be replaced with "for instance https://example.com/my-category?price=-100%27[0]" - the "/" before the ? should be removed. I believe in 2.3 version Your reported the issue on it was reproduced with that slash, but as far as I remember there was a commit that brought some changes to category url behavior depending on presence of such a slash in it. So probably that is the reason the issue needs now to have category url be without slash before request part (before ?) in order to get reproduced. So we are proceeding with testing Your PR.

[engcom-Bravo]

@ihor-sviziev, everyting works fine, sorry for disturbing You. ✔️ QA Passed.

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[MTheProgrammer]

Hello, this is still an issue in Magento 2.4.2:

[2021-08-17 02:41:49] main.CRITICAL: Warning: A non-numeric value encountered in XXXX/vendor/magento/module-catalog-search/Model/Layer/Filter/Price.php on line 194 [] []

Type in the url non-numeric value for the price filter:
https://magento.domain/category.html?price=c-d

[ihor-sviziev]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @ihor-sviziev, here is your Magento Instance: https://1f4f5d16fa7d1b45781c91cc4946a511-2-4-develop.instances.magento-community.engineering
Admin access: https://1f4f5d16fa7d1b45781c91cc4946a511-2-4-develop.instances.magento-community.engineering/admin_0b70
Login: 69ae353d
Password: 9b278dc3c9ce

[ihor-sviziev]

Hi @MTheProgrammer,
I can't reproduce the issue on the 2.4-develop issue both on the test instance and on the local machine.
Tested on the following page with deployed sample data:
https://1f4f5d16fa7d1b45781c91cc4946a511-2-4-develop.instances.magento-community.engineering/training/training-video.html?price=c-d
https://app.magento24.test/training/training-video.html?price=c-d

If you are still able to reproduce it - please create a separate issue with steps to reproduce.
Thank you!