Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Email address mismatch with text in iPad(768) view issue25935 #25942

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve Email address mismatch with text in iPad(768) view #25935: Email address mismatch with text in iPad(768) view

Fixed Issues (if relevant)

  1. Email address mismatch with text in iPad(768) view #25935: Email address mismatch with text in iPad(768) view

Manual testing scenarios (*)

  1. Front end
  2. Register with email like "renard1.abcdefgtest56sdfsdfsdfsdfsdssshijklm@gmail.com"
  3. Review the my account dashboard in iPad view

Expected result

Email should not be mismatch with edit link

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 7, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@edenduong
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request.
Unfortunately, I can only deploy instances for 2.2-develop and 2.3-develop base branches

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6423 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@krzksz krzksz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 7, 2019
@engcom-Alfa engcom-Alfa self-assigned this Dec 8, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@sdzhepa
Copy link
Contributor

sdzhepa commented Dec 9, 2019

@magento give me test instance

1 similar comment
@sdzhepa
Copy link
Contributor

sdzhepa commented Dec 9, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-25942.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email address mismatch with text in iPad(768) view
6 participants