-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set empty value to color picker when input is reset to update preview #26044
Conversation
Hi @gperis. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
…view gets updated
As the functionality is used only in Adobe Stock Integration UI - should be covered by functional tests as part of Adobe Stock Integration |
Hi @sivaschenko, thank you for the review. |
✔️ QA passed |
Hi @gperis, thank you for your contribution! |
Description (*)
When the color picker input is reset by an event, the preview doesn't update accordingly as the value is undefined and the logic to update it gets skipped. With this change, if the value is undefined, we set it to an empty value.
Fixed Issues (if relevant)
Manual testing scenarios (*)
I couldn't find any areas in the core where the color picker is being used as part of the grid filters in the backend.
Questions or comments
It would be nice to get some feedback on the fix and if there is a better way to deal with the issue.
Contribution checklist (*)