Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set empty value to color picker when input is reset to update preview #26044

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

gperis
Copy link
Contributor

@gperis gperis commented Dec 14, 2019

Description (*)

When the color picker input is reset by an event, the preview doesn't update accordingly as the value is undefined and the logic to update it gets skipped. With this change, if the value is undefined, we set it to an empty value.

Fixed Issues (if relevant)

  1. The Color picker is not reset on switching bookmarks adobe-stock-integration#822: The Color picker is not reset on switching bookmarks

Manual testing scenarios (*)

I couldn't find any areas in the core where the color picker is being used as part of the grid filters in the backend.

  • From Magento Admin go to Content - Pages, click Add New Page
  • Expand Content Click Show / Hide Editor, select Insert Image...
  • Click Search Adobe Stock
  • Create a new Filter view
  • Click Filters and Apply any filter, Price - Standard for example (this step is done to enable Save View As button)
  • Click Default View dropdown and select Save View As...
  • Type in "New View", for example, and click Enter key
  • Click on the Color square and select any color, Black for example
  • Do not Apply it, switch to Default View and observe the Color square

Questions or comments

It would be nice to get some feedback on the fix and if there is a better way to deal with the issue.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@gperis gperis requested a review from DrewML as a code owner December 14, 2019 13:50
@m2-assistant
Copy link

m2-assistant bot commented Dec 14, 2019

Hi @gperis. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added partners-contribution Pull Request is created by Magento Partner Partner: Monsoon labels Dec 14, 2019
@sivaschenko
Copy link
Member

As the functionality is used only in Adobe Stock Integration UI - should be covered by functional tests as part of Adobe Stock Integration

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-6467 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@magento-engcom-team magento-engcom-team merged commit b0d2f65 into magento:2.4-develop Dec 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2019

Hi @gperis, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Ui Partner: Monsoon partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants