Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Downloadable] Cover Helper Data by Unit Test #26045

Conversation

edenduong
Copy link
Contributor

Description (*)

Increase Test Coverage

[Downloadable] Cover Helper Data by Unit Test

Magento\Downloadable\Helper\Data

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

vendor/bin/phpunit app/code/Magento/Downloadable/Test/Unit/Helper/DataTest.php

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 14, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-6470 has been created to process this Pull Request

@lbajsarowicz
Copy link
Contributor

@kalpmehta Shouldn't we aim to reduce the number of helpers, instead of covering them with tests? If there's a need to get configuration values, in my opinion, we should introduce ConfigProviderInterface - for example.

@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants