Fixed Issue with tier price 0 when saving product second time

[ravi-chandra3197]

Description (*)

Fixed Issue with tier price 0 when saving product second time

Fixed Issues (if relevant)

1. Issue with tier price 0 when saving product second time #25195: Issue with tier price 0 when saving product second time Issue with tier price 0 when saving product second time #25195

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Hi, @ravi-chandra3197. Please, cover your change by an automated test. It's a required step for further PR processing. I would suggest adjusting the existing unit test for this purpose.

Thank you.

[ravi-chandra3197]

Hi, @ravi-chandra3197. Please, cover your change by an automated test. It's a required step for further PR processing. I would suggest adjusting the existing unit test for this purpose.

Thank you.

Hello @rogyar
I have added an automated test in the existing unit test.
can review it.

[rogyar]

Hi @ravi-chandra3197.

Thank you for the update. Let me help you with this one a little bit. Asserting the null value in the unit tests does not cover the case we are trying to fix here. In order to check our change works as expected, we need to pass an empty array element in the $update array upon invoking the updateValues method. After that, we need to make sure that updateValues method returns true.
The second assertion should check that we have false as a result of updateValues method in case if we are passing null as an element of $valuesToUpdate parameter.

[engcom-Echo]

I will take care of fix static tests.

[Nazar65]

@magento run unit tests

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-6647 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.