Static properties serialization fix.

[p-bystritsky]

Description (*)

When test cleanup is disabled, Magento\TestFramework\Workaround\Cleanup\StaticProperties is caching static variables before the integration test starts, and restoring them after the test run is finished (if some instance of \Magento\TestFramework\TestCase\AbstractController has run).
Serialization and unserialization of static properties are provided by Magento\Framework\Serialize\Serializer\Json class, which wraps json_encode and json_decode functions.
Some of static properties are objects (e. g. \Magento\Framework\Autoload\AutoloaderRegistry::$autoloader). After encoding and decoding these properties through JSON we are getting arrays instead of objects. So we are facing issues on consecutive runs of integration tests.

Fixed Issues (if relevant)

1. None

Manual testing scenarios (*)

1. Disable the application cleanup in integration tests phpunit.xml:
   <const name="TESTS_CLEANUP" value="disabled"/>
2. Run some controller integration test (e. g. \Magento\Newsletter\Controller\ManageTest)
3. Run some another controller integration test (e. g. AdminNotification test bundle)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Static properties serialization fix. #28319: Static properties serialization fix.

Resolved issues:

1. resolves [Issue] Static properties serialization fix. #29313: Static properties serialization fix.

[m2-assistant]

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

Hi @p-bystritsky,
Could you review test failures and fix your solution?

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7142 has been created to process this Pull Request

[engcom-Echo]

@magento run all tests

[ihor-sviziev]

@engcom-Alfa @engcom-Echo I see this PR in testing more than 1 month. I think you just missed it

[engcom-Echo]

✔️ QA Passed

✖️ Before:

✔️ After:

[slavvka]

@magento run Integration Tests

[slavvka]

@p-bystritsky Integration tests are failing again. Could you please fix them?

[VladimirZaets]

@magento create issue

[engcom-Echo]

@magento run all tests

[ihor-sviziev]

@slavvka integration test are not failing on CI before & after merging 2.4-develop branch. Where we can see that they were failing?
https://github.com/magento/magento2/pull/26175/checks?check_run_id=945245712

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-7142 has been created to process this Pull Request

[slavvka]

@magento run all tests

[m2-assistant]

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.