Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed Regular Price Label Alignment Issues in Frontend] #26247

Conversation

hitesh-wagento
Copy link
Contributor

@hitesh-wagento hitesh-wagento commented Jan 3, 2020

Description (*)

Fixed Regular Price Label Alignment Issues in Frontend

Fixed Issues (if relevant)

  1. Regular Price Label Alignment Issues in Frontend #25936: Regular Price Label Alignment Issues in Frontend

Manual testing scenarios (*)

  1. Admin->Catalog->Products->Add Product
  2. Add Price ex:$23
  3. Click on Advanced Pricing and add special price ex:$13
  4. Save the product
  5. Open product in frontend

Expected result (*)

  1. Advanced Pricing should be Aligned in single line

regularprice-expectedresult

Actual result (*)

  1. Advanced Pricing Alignment is not Proper

regularprice-actuvalresult

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jan 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 3, 2020

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hitesh-wagento,
unfortunately, the current solution is rather a workaround and it does not seem to be solving the real issue.
The title text can be longer with another language pack.

Thank you!

@ghost ghost assigned dmytro-ch Jan 3, 2020
@dmytro-ch
Copy link
Contributor

dmytro-ch commented Jan 3, 2020

Closing this PR in favor of #26237.

@dmytro-ch dmytro-ch closed this Jan 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 3, 2020

Hi @hitesh-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: needs update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants